docs: collapse redundant frontend test commands in SETUP.md#87
Merged
Conversation
Merged
Co-authored-by: dan323 <32780500+dan323@users.noreply.github.com> Agent-Logs-Url: https://github.com/dan323/natural-deduction/sessions/c75973e4-b1cd-4677-92a2-fb1ef3782a06
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on documentation updates from PR #86 review
docs: collapse redundant frontend test commands in SETUP.md
Mar 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the developer setup documentation to remove redundant frontend testing instructions and clarify that running frontend tests already collects coverage.
Changes:
- Collapsed duplicate “Run all tests” / “Run with coverage” blocks into a single
npm testinstruction. - Added an inline note clarifying coverage is collected by default for frontend tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dan323
added a commit
that referenced
this pull request
Mar 23, 2026
* Update docs * docs: collapse redundant frontend test commands in SETUP.md (#87) * Initial plan * Collapse redundant frontend test commands into single instruction Co-authored-by: dan323 <32780500+dan323@users.noreply.github.com> Agent-Logs-Url: https://github.com/dan323/natural-deduction/sessions/c75973e4-b1cd-4677-92a2-fb1ef3782a06 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: dan323 <32780500+dan323@users.noreply.github.com> * Fix dev proxy config and docs: add Vite proxy for /logic, remove unused BASE_URL --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Frontend Tests section listed "Run all tests" and "Run with coverage" as separate steps with identical
npm testcommands, which was misleading and redundant.Changes
docs/SETUP.md: Merged the two blocks into a single instruction —npm test— with an inline note that coverage is collected by default.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.